clerie/bahn-insight
1
0
Fork 0
Code Releases Activity

Replace innerHTML hack with proper DOM manipulation

Browse Source
This commit is contained in:
clerie 2020-09-16 14:53:04 +02:00
parent d3d1aeecd8
commit bf884ac39c
1 changed files with 31 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
js/reiseauskunft.js
View File

@ -32,6 +32,31 @@ function bahnParseTrainName(dirty_train_name) {
return dirty_train_name; return dirty_train_name;
} }
function domCreateLink(href) {
var link = document.createElement("a");
link.setAttribute("href", href);
return link;
}
function domCreateImage(src) {
var image = document.createElement("img");
image.setAttribute("src", src);
return image;
}
function domCreateButton(href, image_src) {
var link = domCreateLink(href);
var image = domCreateImage(image_src);
image.setAttribute("style", "height: 2em; vertical-align:middle;")
link.append(image);
return link;
}
function domCreateButtonMarudor(path) {
var button = domCreateButton("https://marudor.de" + path, getMediaURL("marudor.svg"));
return button;
}
var connection_result_observer = new MutationObserver((mutations) => { var connection_result_observer = new MutationObserver((mutations) => {
mutations.forEach((mutation) => { mutations.forEach((mutation) => {
if (mutation.type === 'childList') { if (mutation.type === 'childList') {
@ -43,9 +68,10 @@ var connection_result_observer = new MutationObserver((mutations) => {
trains.forEach((train) => { trains.forEach((train) => {
var train_names = train.querySelectorAll("span a"); var train_names = train.querySelectorAll("span a");
train_names.forEach((train_name) => { train_names.forEach((train_name) => {
train_name = bahnParseTrainName(train_name.innerText); train_name_text = bahnParseTrainName(train_name.innerText);
if(typeof train_name !== 'undefined') { if(typeof train_name_text !== 'undefined') {
train.innerHTML = train.innerHTML + ' <a href="https://marudor.de/details/' + train_name + '" target="_blank"><img src="' + getMediaURL("marudor.svg") + '" style="height: 2em; vertical-align:middle;"></a>'; var marudor_button = domCreateButtonMarudor("/details/" + train_name_text);
train_name.after(marudor_button);
} }
}); });
}); });
@ -53,7 +79,8 @@ var connection_result_observer = new MutationObserver((mutations) => {
var stations = timetable.querySelectorAll("tr td.station"); var stations = timetable.querySelectorAll("tr td.station");
stations.forEach((station) => { stations.forEach((station) => {
var station_name = station.innerText; var station_name = station.innerText;
station.innerHTML = station.innerHTML + ' <a href="https://marudor.de/' + station_name + '" target="_blank"><img src="' + getMediaURL("marudor.svg") + '" style="height: 2em; vertical-align:middle;"></a>'; var marudor_button = domCreateButtonMarudor("/" + station_name);
station.append(marudor_button);
}); });
} }